]> dgit.raspbian.org Git - gnome-shell.git/commitdiff
gdm: Ensure we cancel all the previously running services on auth retry
authorMarco Trevisan (Treviño) <mail@3v1n0.net>
Tue, 2 Feb 2021 16:29:29 +0000 (17:29 +0100)
committerMarge Bot <marge-bot@gnome.org>
Fri, 12 Feb 2021 20:26:00 +0000 (20:26 +0000)
When retrying the authentication we should make sure that all the
previously initiated services are stopped in order to begin a new
authentication session with all the configured services.

Unfortunately at the current state we only dispose the currently used
user verifier, but we don't make it to stop all the relative gdm workers
and then they'll stay around potentially blocking any further usage of
them (as it happens with the fingerprint one, that has unique access to
the device).

So, cancel the currently running authentication before starting a new
one if we're explicitly retrying.

Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1622>

js/gdm/util.js

index a35ab94b981ae3e78a1fdc5cd63f4e8e9ff410a1..320d2f826c66bec49e3392ff974d9fa0bd885760 100644 (file)
@@ -591,6 +591,7 @@ var ShellUserVerifier = class {
     }
 
     _retry() {
+        this.cancel();
         this.begin(this._userName, new Batch.Hold());
     }